search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
29 stars 110 forks source link

Fix for broken links to adopters on index page #843

Closed netmenya closed 2 years ago

netmenya commented 2 years ago

Signed-off-by: katyamarova marova.ekaterina@gmail.com

What this PR does / why we need it: Bugfix. Links to adopters on index page has missing href attributes.

Does this PR fix any issue?:

Fixes #842

kubevirt-bot commented 2 years ago

Hi @netmenya. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mazzystr commented 2 years ago

/ok-test-test

Oh! Thanks for catching this bug! Let's test and see how netlify renders the fix. If the front page looks good and link checks pass we can merge immediately.

On Thu, May 12, 2022, 4:53 AM Katya Marova @.***> wrote:

Signed-off-by: katyamarova @.***

What this PR does / why we need it: Bugfix. Links to adopters on index page has missing href attributes.

Does this PR fix any issue?:

Fixes #842 https://github.com/kubevirt/kubevirt.github.io/issues/842

You can view, comment on, or merge this pull request online at:

https://github.com/kubevirt/kubevirt.github.io/pull/843 Commit Summary

File Changes

(1 file https://github.com/kubevirt/kubevirt.github.io/pull/843/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/kubevirt/kubevirt.github.io/pull/843, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS5KZ4WIPLDHHOV6KAR2JTVJTWKJANCNFSM5VX7YKSA . You are receiving this because your review was requested.Message ID: @.***>

mazzystr commented 2 years ago

Netlify looks great. Links check out.

/lgtm /approve

Thanks for the quick fix!

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mazzystr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/main/OWNERS)~~ [mazzystr] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment