search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
29 stars 110 forks source link

Removing explicit GMT timezone set in the website calendar link so that it displays in local time #847

Closed aburdenthehand closed 2 years ago

aburdenthehand commented 2 years ago

Calendar link currently explicitly set to GMT in the website link. Removing this should mean the calendar is accurate for viewer timezone. Previously it did mention that times were shown in GMT, but it was in tiny font at bottom of screen and very easy to miss.

Signed-off-by: aburdenthehand aburden@redhat.com

Special notes for your reviewer: Tested by changing local timezone and opening new link. Calendar showed expected meeting times as per local timezone.

kubevirt-bot commented 2 years ago

Hi @aburdenthehand. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
brianmcarey commented 2 years ago

/ok-to-test

cwilkers commented 2 years ago

Good idea, /approve

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cwilkers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/main/OWNERS)~~ [cwilkers] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment