search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
30 stars 112 forks source link

Fix getting the latest CDI version in lab2 #868

Closed dermorz closed 2 years ago

dermorz commented 2 years ago

What this PR does / why we need it: While doing the KubeVirt Labs I noticed that VERSION was not set using the snippet to install the CDI. Github is responding with a HTTP redirect, so the latest version needs to be grabbed from the location header instead of the response body.

kubevirt-bot commented 2 years ago

Hi @dermorz. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cwilkers commented 2 years ago

Hi, thanks for your PR!

For consistency, we just merged a PR to our user-guide for this same issue, and it uses a safer method to query the actual release tag redirected from /latest. Would you mind updating yours to match?

https://github.com/kubevirt/user-guide/pull/559

dermorz commented 2 years ago

Hi @cwilkers,

I don't mind at all. I just proposed what was fixing it for me locally. The other solution looks way safer and cleaner. Will update my pr.

kubevirt-bot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cwilkers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/main/OWNERS)~~ [cwilkers] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment