Closed hindu-muppala closed 1 year ago
Hi @hindu-muppala. Thanks for your PR.
I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test Thanks for this PR, we really have been behind updating the upgrade lab.
Have you tested that the lab works with the versions you added?
As a side note, we could really use this lab in our Killercoda scenarios. There is an even older version of this one there, but it has not been updated since the Katacoda days. It would need not only an update to the version numbers themselves, but some scripting to set up the environment in a way that matches our other updated labs. Would you be interested in attempting this? The repo is kubevirt/katacoda-scenarios, specifically https://github.com/kubevirt/katacoda-scenarios/tree/main/kubevirt-upgrades
I will test soon and report.
@cwilkers ,Yes, I interested to do as you suggest. Can you provide guidance to me?. So that I will complete this issue.
Thanks @hindu-muppala Let's use this issue for the lab here. I have created another issue for the Killercoda / katacoda-scenarios repo: https://github.com/kubevirt/katacoda-scenarios/issues/39
I'm not sure if you mentioned; did you complete your test?
@cwilkers I tested through killerconda,
$ kubectl wait --for condition=ready pod -l kubevirt.io=virt-operator -n kubevirt --timeout=100s
pod/virt-operator-5ddb4674b9-6fbrv condition met
I am getting error for this command like this:- Can I know is any mistake done by me. Other commands are working fine.
It seems the second line is supposed to be output, not part of the command.
On Wed, Apr 26, 2023 at 12:43 PM Hindu Muppala @.***> wrote:
@cwilkers https://github.com/cwilkers I tested through killerconda,
$ kubectl wait --for condition=ready pod -l kubevirt.io=virt-operator -n kubevirt --timeout=100s pod/virt-operator-5ddb4674b9-6fbrv condition met
I am getting error for this command like this:- [image: image] https://user-images.githubusercontent.com/120579608/234659099-533b2f75-4a30-4c2f-8f6e-68c5a8c2d719.png Can I know is any mistake done by me. Other commands are working fine.
— Reply to this email directly, view it on GitHub https://github.com/kubevirt/kubevirt.github.io/pull/900#issuecomment-1523815677, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFKRM4VFWEMMKSQIYLWBPWDXDFNCZANCNFSM6AAAAAAW7DKOLA . You are receiving this because you were mentioned.Message ID: @.***>
-- Chandler Wilkerson, RHCE, CKA Sr. Software Engineer
Red Hat
Tests that are failed Test 1 Error due to following command order:- Instead of this commands order should be: command1:-$ kubectl create -f https://github.com/kubevirt/kubevirt/releases/download/${KUBEVIRT_VERSION}/kubevirt-cr.yaml command 2:- $ kubectl -n kubevirt patch kubevirt kubevirt --type=merge --patch '{"spec":{"configuration":{"developerConfiguration":{"useEmulation":true}}}}' The order of commands in kubevirt website should be changed as above .If I run commands order like this , I did not get any error. Test 2 updating version Showing error that kubevirt already exit. @cwilkers ,please review my test review.
Instead of this [...] the order of commands in kubevirt website should be changed as above .If I run commands order like this , I did not get any error.
Good catch, the patch was a late addition to the lesson and may have made it in the incorrect order due to lack of testing at the time.
Test 2 updating version Showing error that kubevirt already exit.
If we are changing the version by updating the CR to the newer version, that should likely be an "apply" operation instead of a "create".
@cwilkers ,I changed the command order in docs and I tested the tests in killerconda,all are passed. Please review and give feedback . Once thing I notice is there is no information about who to Install Virtctl. If required, I will add in docs. By adding below information.
Install Virtctl
While we are waiting for the KubeVirt operator to start up all its Pods, we can take some time to download the client we will need to use in the next step.
virtctl is a client utility that helps interact with VM's (start/stop/console, etc):
wget -O virtctl https://github.com/kubevirt/kubevirt/releases/download/${KUBEVIRT_VERSION}/virtctl-${KUBEVIRT_VERSION}-linux-amd64
chmod +x virtctl
@cwilkers ,I did the changes recommended. Please review and give feedback.
Everything looks good, thanks for all your work in updating this lesson!
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cwilkers
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it:
Does this PR fix any issue? _(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged)_:Special notes for your reviewer: Updated version form 0.20.1 to 0.56.1. Please review and give feedback.