Closed maiqueb closed 1 year ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/cc @phoracek
/cc @jcaamano
@maiqueb: GitHub didn't allow me to request PR reviews from the following users: jcaamano.
Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs.
/lgtm /approve /hold
Holding for @cwilkers to get a chance to +1 or -1 this too
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: phoracek
The full list of commands accepted by this bot can be found here.
The pull request process is described here
I did a quick skim, the examples look good to me now. Thanks!
/release-hold /lgtm
@cwilkers did you mean to /hold cancel
?
(I'm unaware if /release-hold
is supposed to work, but looks like it didn't ...)
/hold cancel
going ahead with it.
Thanks all.
@maiqueb Oops, I looked up the commands and mis-remembered remove-hold
. In completely random news, there is also a /honk command to add a goose to a PR. Do with that knowledge what you will.
This type of networks allows connectivity to the physical network underlay.
What this PR does / why we need it: This PR shows how to create OVN-K secondary networks to interconnect VMs on an SDN network with access to the physical network underlay.
Does this PR fix any issue? _(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged)_:Special notes for your reviewer: