kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
29 stars 109 forks source link

blog: post about secondary ovn-k localnet networks #907

Closed maiqueb closed 1 year ago

maiqueb commented 1 year ago

This type of networks allows connectivity to the physical network underlay.

What this PR does / why we need it: This PR shows how to create OVN-K secondary networks to interconnect VMs on an SDN network with access to the physical network underlay.

Does this PR fix any issue? _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_:

Fixes #

Special notes for your reviewer:

kubevirt-bot commented 1 year ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

maiqueb commented 1 year ago

/cc @phoracek

maiqueb commented 1 year ago

/cc @jcaamano

kubevirt-bot commented 1 year ago

@maiqueb: GitHub didn't allow me to request PR reviews from the following users: jcaamano.

Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubevirt/kubevirt.github.io/pull/907#issuecomment-1568735911): >/cc @jcaamano Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
phoracek commented 1 year ago

/lgtm /approve /hold

Holding for @cwilkers to get a chance to +1 or -1 this too

kubevirt-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cwilkers commented 1 year ago

I did a quick skim, the examples look good to me now. Thanks!

/release-hold /lgtm

maiqueb commented 1 year ago

@cwilkers did you mean to /hold cancel ?

(I'm unaware if /release-hold is supposed to work, but looks like it didn't ...)

maiqueb commented 1 year ago

/hold cancel

going ahead with it.

Thanks all.

cwilkers commented 1 year ago

@maiqueb Oops, I looked up the commands and mis-remembered remove-hold. In completely random news, there is also a /honk command to add a goose to a PR. Do with that knowledge what you will.