Closed lyarwood closed 4 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
I have just a few comments, mostly for possible clarification. All can probably be safely ignored.
I like the blog post, very informative and written for easy understanding.
Thanks, I'll clean this up tomorrow. FWIW this is based on the following personal blog post, I've dropped the bugfix section as I'm not sure how useful that would be in this particular blog:
https://blog.yarwood.me.uk/2023/06/22/kubevirt_instancetype_update_5/
@jobbler @cwilkers I forgot to follow up with this after the v1.0.0
release, do you think this can be published now?
/close
@lyarwood: Closed this PR.
/reopen
@lyarwood: Reopened this PR.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign davidvossel for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen
.
Mark the issue as fresh with /remove-lifecycle rotten
.
/close
@kubevirt-bot: Closed this PR.
What this PR does / why we need it:
Adds a
instancetype.kubevirt.io/v1beta1
update blog post based on a personal blog post I've written below :https://blog.yarwood.me.uk/2023/06/22/kubevirt_instancetype_update_5/
Does this PR fix any issue? _(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged)_:Special notes for your reviewer: