kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
29 stars 109 forks source link

localnet: various small fixes #913

Closed oshoval closed 9 months ago

oshoval commented 11 months ago

What this PR does / why we need it: Fix small incorrect details on the first example. Add docker underlay bridge name detection command.

Does this PR fix any issue? _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_:

Fixes #

Special notes for your reviewer:

oshoval commented 11 months ago

/cc @maiqueb

oshoval commented 10 months ago

Addressed comments

cwilkers commented 10 months ago

Hi! If you still want all your code blocks to look the same (they really render differently between the code blocks and triple-backticks) I figured out an escape for the {{ literal:

podman network inspect underlay --format '{{ "{{" }} .NetworkInterface }}'
maiqueb commented 10 months ago

Hi! If you still want all your code blocks to look the same (they really render differently between the code blocks and triple-backticks) I figured out an escape for the {{ literal:

podman network inspect underlay --format '{{ "{{" }} .NetworkInterface }}'

@oshoval please try this out !!! Thanks @cwilkers !

oshoval commented 10 months ago

Hi! If you still want all your code blocks to look the same (they really render differently between the code blocks and triple-backticks) I figured out an escape for the {{ literal:

podman network inspect underlay --format '{{ "{{" }} .NetworkInterface }}'

Thanks, trying to see how it looks like on netlify EDIT - nice, it works good on the blog (not on the markdown, but what matters is the blog) will adapt all the places and address rest of the comments

oshoval commented 10 months ago

Due to the latest changed the comments are outdated pushed the changes, ptal

oshoval commented 10 months ago

Addressed comments

oshoval commented 10 months ago

@maiqueb can you please take another look ?

maiqueb commented 10 months ago

/lgtm

phoracek commented 9 months ago

/approve

kubevirt-bot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/main/OWNERS)~~ [phoracek] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment