search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
29 stars 109 forks source link

Update CDI lab to match the current behavior #914

Closed alromeros closed 10 months ago

alromeros commented 11 months ago

What this PR does / why we need it:

The CDI lab in kubevirt.io contains out-of-date processes and information, to the point where it recommends the creation of a PVC with import annotations instead of a DataVolume. The given example simply doesn't work with the latest CDI version.

Though we plan to eventually change the way CDI works with DataVolumes (check https://github.com/kubevirt/containerized-data-importer/pull/2752 for more information), the lab should at least provide a working example so users can test CDI's latest versions.

With the adoption of populators this process will require an update again soon, but since users have been reporting issues with the current lab (https://github.com/kubevirt/containerized-data-importer/issues/2830 or https://github.com/kubevirt/containerized-data-importer/issues/2645#issuecomment-1489913173) at least we should fix it for the moment.

cwilkers commented 10 months ago

/lgtm /approve

kubevirt-bot commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cwilkers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/main/OWNERS)~~ [cwilkers] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment