search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
29 stars 109 forks source link

Add blog on KubeVirt and Cluster Autoscaler #918

Closed relaxdiego closed 9 months ago

relaxdiego commented 10 months ago

What this PR does / why we need it:

This cross-posts a blog post on using KubeVirt with Cluster Autoscaler. The original can be found at: https://relaxdiego.com/2023/08/kubevirt-cas-baremetal.html

kubevirt-bot commented 10 months ago

Hi @relaxdiego. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
relaxdiego commented 9 months ago

Thanks for the review @aburdenthehand! Will get those changes in soon.

aburdenthehand commented 9 months ago

Looks good @relaxdiego - the only thing is we need you to sign your previous commit. I believe git commit --amend --signoff --no-edit should do the trick (since it was only the previous one commit that wasn't signed)

relaxdiego commented 9 months ago

Thanks @aburdenthehand! Added the missing sign-off.

aburdenthehand commented 9 months ago

/lgtm Thanks Mark!

cwilkers commented 9 months ago

Nice work! Thanks for the post

/approve

kubevirt-bot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cwilkers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/main/OWNERS)~~ [cwilkers] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
relaxdiego commented 9 months ago

Thanks for accepting this contribution!