search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
29 stars 109 forks source link

Add aburden as approver, put mazzystr to emeritus #925

Closed dhiller closed 7 months ago

dhiller commented 7 months ago

What this PR does / why we need it: Adds @aburdenthehand as approver, since he's the community facilitator.

Puts @mazzystr to emeritus approvers and removes him from reviewers, since he's gone to NASA :smiling_face_with_tear:

Does this PR fix any issue? _(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged)_:

Fixes #

Special notes for your reviewer: /cc @fabiand @stu-gott

aburdenthehand commented 7 months ago

Thanks @dhiller :) And my contributions to this repo: Authored PRs: 16 Reviews: 4

Did you want to add me to the list of reviewers as well so I get picked up by the bot on new PRs?

dhiller commented 7 months ago

Thanks @dhiller :) And my contributions to this repo: Authored PRs: 16 Reviews: 4

Did you want to add me to the list of reviewers as well so I get picked up by the bot on new PRs?

Very good point. I also removed @mazzystr from the reviewers on that note.

dhiller commented 7 months ago

@cwilkers do you have time to take a quick look at this?

cwilkers commented 7 months ago

@dhiller +1 for keeping things alphabetized :-) /lgtm /approve

kubevirt-bot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cwilkers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/main/OWNERS)~~ [cwilkers] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment