search

kubevirt / kubevirt.github.io

KubeVirt website repo, documentation at https://kubevirt.io/user-guide/
https://kubevirt.io
MIT License
29 stars 109 forks source link

Removing NoVNC blog #926

Closed aburdenthehand closed 7 months ago

aburdenthehand commented 7 months ago

The NoVNC component has been identified as vulnerable and that this blog shows how to bypass authentication. @fabiand @rmohr

rmohr commented 7 months ago

/approve

Probably some stale links still included from CI results?

aburdenthehand commented 7 months ago

Good point, it had some links to it in a UI blog. That blog is also out of date but I don't think it's worth removing. I've dropped the lines containing the xrefs but have not removed the noVNC section from the UI blog.

rmohr commented 7 months ago

/lgtm

aburdenthehand commented 7 months ago

/approve

kubevirt-bot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aburdenthehand, rmohr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirt.github.io/blob/main/OWNERS)~~ [aburdenthehand] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment