Closed aburdenthehand closed 7 months ago
cwilkers
commented
7 months ago I think the actual permissions are handled in project-infra: here
This file doesn't exactly match what is there, so I'm not sure how it gets generated (if it is generated) and if it has an effect.
aburdenthehand
commented
7 months ago Hmm, interesting. I always thought the owners file in each repo is processed by kubevirt-bot when it comes to assigning a reviewer and also providing approval rights, and the teams listed in orgs.yaml are an additional layer of more granular permissions that can be applied to multiple repos. In truth I'm just copying what @dhiller did recently on #925 :)
cwilkers
commented
7 months ago That makes sense, perhaps some of the process is in the version from project-infra, and some of it is the local OWNERS file. (I had forgotten to check what file I was approving for that previous PR actually--it only occurred to me the second time around)
Any way, welcome and thanks @jean-edouard !
/lgtm /approve
kubevirt-bot
commented
7 months ago [APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cwilkers
The full list of commands accepted by this bot can be found here.
The pull request process is described here
My understanding is John is no longer involved with the project in any major way. As such I've removed him as a reviewer. Jed (@jean-edouard) has kindly volunteered to become a reviewer for this repo. Jed is an approver of kubevirt/kubevirt and has contributed 4 blogs.