Closed elchenberg closed 3 months ago
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
/remove-lifecycle stale
+1
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen
.
Mark the issue as fresh with /remove-lifecycle rotten
.
/close
@kubevirt-bot: Closing this issue.
Is your feature request related to a problem? Please describe: A clear and concise description of what the problem is.
I want to collect the kubevirt-prometheus-metrics. I have configured KubeVirt to create a service monitor:
This seems to work without issues because now there is a ServiceMonitor in my kubevirt namespace. But the metrics are not collected because my Prometheus is configured with a
serviceMonitorSelector
:I could not find a way to tell KubeVirt to add this label to the ServiceMonitor.
Describe the solution you'd like: A clear and concise description of what you want to happen.
The KubeVirt CRD has a
serviceMonitorSelector
(orserviceMonitorLabel
,serviceMonitorAdditionalLabels
, ...) setting that can be used to configure a label that will be added to the ServiceMonitor, for example:Describe alternatives you've considered: A clear and concise description of any alternative solutions or features you've considered.
I added the label manually and Prometheus started to scrape the metrics. But since the ServiceMonitor is managed by the virt-operator I would like to avoid manual changes.
Additional context: Add any other context or screenshots about the feature request here.
Kubevirt v1.0.0