search

kubevirt / kubevirt

Kubernetes Virtualization API and runtime in order to define and manage virtual machines.
https://kubevirt.io
Apache License 2.0
5.57k stars 1.33k forks source link

VM snapshot finalizers are being left on VMs after snapshot finishes #11432

Closed alromeros closed 4 months ago

alromeros commented 7 months ago

What happened:

This is an issue to track the behavior described in PRs such as https://github.com/kubevirt/kubevirt/pull/10775 and https://github.com/kubevirt/kubevirt/pull/11244.

Basically, we've been experiencing issues with VM snapshot-related finalizers being left when they shouldn't, preventing the deletion of VMs. This is triggering issues in some of our tests.

A fix is in the works, so this issue should only work as a tracker.

What you expected to happen:

Finalizers should be removed after the VM snapshot fails or succeeds.

How to reproduce it (as minimally and precisely as possible):

For example, the test quarantined in https://github.com/kubevirt/kubevirt/pull/11244 could replicate this issue consistently.

alromeros commented 7 months ago

/cc @mhenriks

kubevirt-bot commented 4 months ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

mhenriks commented 4 months ago

fixed in #11241

alromeros commented 4 months ago

Great, thanks Michael. Closing this issue.