search

kubevirt / kubevirt

Kubernetes Virtualization API and runtime in order to define and manage virtual machines.
https://kubevirt.io
Apache License 2.0
5.45k stars 1.31k forks source link

tests/utils.go: Move or inline DeleteAlpineWithNonQEMUPermissions to the place where it is used #11442

Closed 0xFelix closed 1 month ago

0xFelix commented 6 months ago

Is your feature request related to a problem? Please describe:

The function DeleteAlpineWithNonQEMUPermissions in tests/utils.go is only used in a single place, so it could be easily moved there.

Describe the solution you'd like:

Move or inline DeleteAlpineWithNonQEMUPermissions to the place where it is used. (tests/storage/storage.go)

0xFelix commented 6 months ago

/sig code-quality

alicefr commented 6 months ago

/label good-first-issue

sarthaksarthak9 commented 6 months ago

/assign

kubevirt-bot commented 3 months ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt-bot commented 2 months ago

Stale issues rot after 30d of inactivity. Mark the issue as fresh with /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

kubevirt-bot commented 1 month ago

Rotten issues close after 30d of inactivity. Reopen the issue with /reopen. Mark the issue as fresh with /remove-lifecycle rotten.

/close

kubevirt-bot commented 1 month ago

@kubevirt-bot: Closing this issue.

In response to [this](https://github.com/kubevirt/kubevirt/issues/11442#issuecomment-2266717223): >Rotten issues close after 30d of inactivity. >Reopen the issue with `/reopen`. >Mark the issue as fresh with `/remove-lifecycle rotten`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.