search

kubevirt / kubevirt

Kubernetes Virtualization API and runtime in order to define and manage virtual machines.
https://kubevirt.io
Apache License 2.0
5.57k stars 1.33k forks source link

sidecar does not build out of tree #11817

Closed aep closed 5 months ago

aep commented 6 months ago

the sidecar example https://github.com/kubevirt/kubevirt/blob/main/cmd/sidecars/smbios/smbios.go does not build when pulled out of tree.

go mod tidy
go: finding module for package kubevirt.io/kubevirt/pkg/virt-launcher/virtwrap/api
go: found kubevirt.io/kubevirt/pkg/virt-launcher/virtwrap/api in kubevirt.io/kubevirt v1.2.0
go: github.com/openshift/api@v0.0.0: reading github.com/openshift/api/go.mod at revision v0.0.0: unknown revision v0.0.0

there is a nice https://github.com/kubevirt/api package that would work just fine, but its missing the virt-launcher/virtwrap/api

so currently to implement a sidecar, you need to fork kubevirt itself

alicefr commented 6 months ago

/cc @victortoso

victortoso commented 5 months ago

The current usage of kubevirt.io/kubevirt/pkg/virt-launcher/virtwrap/api is only related to schema.go which means it can be replaced by libvirtxml, which is actually preferred. I'm working on doing that from virt-launcher side already too.

somewhat related: https://github.com/kubevirt/kubevirt/issues/10844 /assign