Closed gouyang closed 5 years ago
Running has always been marked as a required field in our API. The only difference now is required fields are being enforced at creation time.
All our example ovms reflect this requirement.
The running is required field and have to be provided. If you do not add running:true|false
than the ovm does not have any information how to proceed. We can discuss whether the ovm should do some defaulting to set default value to be running: false
. @rmohr @fabiand what do you think?
I'd say we can sanely default to running: false
- it would just be a default like with any other field.
I'd say we can sanely default to running: false - it would just be a default like with any other field.
Defaulting running to "false" makes sense when the object is called a OfflineVirtualMachine. What about when we change the name to something like a StatefulVirtualMachine? I'd be confused if I posted a SVM and it didn't run.
The name OVM will change soon. I'd suggest leaving running as a required field until then. After we settle on a name, we can decide what the default should be for running.
I tend to agree with David. running: false
for statefull VM is confusing. Having it required means, user have to decide what he wants to do with it.
I agree the different names may be confusing. I don't agree with putting a burden of the user to have to decide as a simple way out for us (as a general rule of thinking, sometimes we have to)
I agree the different names may be confusing. I don't agree with putting a burden of the user to have to decide as a simple way out for us (as a general rule of thinking, sometimes we have to)
yep, I agree. We need a default. I suggest we hold off on making a decision about the default until after we are 100% committed to a name (ovm vs svm discussion) because the name impacts the default we use.
If I add to
running: false
to the spec section, it works then.