Open 0xFelix opened 1 year ago
IMHO tests cases should never be silently skipped. Thanks for bringing this up, @0xFelix !
In general tests should either be skipped explicitly or fail.
In general tests should either be skipped explicitly or fail.
100% agree!
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
/lifecycle rotten
/remove-lifecycle rotten
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
/lifecycle rotten
/remove-lifecycle rotten
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen
.
Mark the issue as fresh with /remove-lifecycle rotten
.
/close
@kubevirt-bot: Closing this issue.
/reopen /lifecycle frozen
@dhiller: Reopened this issue.
What happened:
Helpers like
libstorage.CreateFSPVC
orlibstorage.CreateBlockPVC
search for a suitable storage classes before creating a PVC. If no storage class was foundSkip
is called and the test case is skipped. This might come as a surprise to test case authors as it is not obvious test cases might be skipped when using those helpers.Several instance type test cases in lane
sig-compute
are affected, because no block storage is available there.See e.g. https://storage.googleapis.com/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/9799/pull-kubevirt-e2e-k8s-1.25-sig-compute/1661927631949402112/artifacts/junit.functest.xml and search for
skipped
.What you expected to happen:
Tests cases should not be silently skipped when a storage class is missing.