search

kubevirt / kubevirtci

Contains cluster definitions and client tools to quickly spin up and destroy ephemeral and scalable k8s and ocp clusters for testing
Apache License 2.0
79 stars 118 forks source link

Convert the vm.sh script into a go binary #1160

Open alicefr opened 5 months ago

alicefr commented 5 months ago

Is your feature request related to a problem? Please describe: Create a go cli that replaces the vm.sh script.

Kuruyia commented 5 months ago

Hi! I'd like to tackle this issue. For this, do we need to move the logic of this script into cluster-provision/gocli?

/assign

alicefr commented 5 months ago

@Kuruyia I'd simply create a new binary and replace the vm.sh with it. Writing a cli tool in bash isn't the nicest thing

Kuruyia commented 5 months ago

Hey @alicefr, I just opened a PR for this issue: #1164 :) I tested this new CLI manually with the steps described in the KUBEVIRTCI_LOCAL_TESTING.md file and I got a cluster up and running.

I'd love to have your input on how to further test this (automatically) and integrate it with the project so we can start using it.

alicefr commented 2 months ago

@anishbista60 there is already an open PR which already address this issue: https://github.com/kubevirt/kubevirtci/pull/1164

Kuruyia commented 2 months ago

That PR should be ready for merging if there are no more reviews btw @alicefr

alicefr commented 2 months ago

@Kuruyia the PR looked already very good to me, I was waiting for @brianmcarey and @dhiller to understand how to integrate it smoothly in the new provider. At least for a release, I would keep the script and the binary in order to be able to roll back if there are any issues.

@brianmcarey @dhiller would you be able to review the PR?