kubevirt / kubevirtci

Contains cluster definitions and client tools to quickly spin up and destroy ephemeral and scalable k8s and ocp clusters for testing
Apache License 2.0
82 stars 119 forks source link

cdi: Deploy latest available CDI manifests on VM #1165

Closed brianmcarey closed 6 months ago

brianmcarey commented 7 months ago

What this PR does / why we need it:

Bump CDI PRs can lead to multiple versions of CDI operator & CR manifests being available. This can cause an error with kubectl create[1]

Only apply the most recent manifests available on the virtual machine

[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirtci/1158/check-provision-k8s-1.29/1774972729217257472#1:build-log.txt%3A2363

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

kubevirt-bot commented 7 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

brianmcarey commented 7 months ago

/test check-provision-k8s-1.29

brianmcarey commented 6 months ago

/test check-provision-k8s-1.29

brianmcarey commented 6 months ago

/test check-provision-k8s-1.29

brianmcarey commented 6 months ago

/test check-provision-k8s-1.29

brianmcarey commented 6 months ago

/cc @xpivarc @dhiller

brianmcarey commented 6 months ago

Forgive me my ignorance, but why do we do this manually now? Is there a problem with the automation?

I see this bump PR, is there something wrong with it?

Yes there is a problem with the bump PR - https://prow.ci.kubevirt.io/pr-history/?org=kubevirt&repo=kubevirtci&pr=1158 - there are multiple CDI manifests available on the node which causes the kubectl create to fail.

kubevirt-bot commented 6 months ago

@brianmcarey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.27-vgpu a77fbd444acfbef317753650dcd485ace5b296d0 link false /test check-up-kind-1.27-vgpu
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kubevirt-bot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirtci/blob/main/OWNERS)~~ [dhiller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment