kubevirt / kubevirtci

Contains cluster definitions and client tools to quickly spin up and destroy ephemeral and scalable k8s and ocp clusters for testing
Apache License 2.0
79 stars 119 forks source link

Add AAQ Operator as an optional cluster addon #1170

Closed Barakmor1 closed 4 months ago

Barakmor1 commented 4 months ago

AAQ Operator will be disabled by default To install AAQ set KUBEVIRT_DEPLOY_AAQ to true before make cluster-up to use custom version set KUBEVIRT_CUSTOM_AAQ_VERSION with the desired version.

What this PR does / why we need it: AAQ is operator used to solve multi-tenancy issue with kubevirt in a kubernetes native way. Adding this addon will help future development of kubevirt policy that define how resource counting should be done with virtual machine workloads.

Development of AAQ will allow replacing workarounds used by some projects using Kubevirt in a multi tenant environments for instance: https://docs.harvesterhci.io/v1.2/rancher/resource-quota/#automatic-adjustment-of-resourcequota-during-migration

For more details about the multi-tenancy issue with kubevirt please see: https://groups.google.com/g/kubevirt-dev/c/lZKEdyNqwsc

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

Add AAQ Operator as an optional cluster addon
Barakmor1 commented 4 months ago

/cc @dhiller @brianmcarey @vladikr

PTAL

kubevirt-bot commented 4 months ago

@Barakmor1: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.27-vgpu 921e38db0d0de0540ada1c778f0154cafd43d982 link false /test check-up-kind-1.27-vgpu
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kubevirt-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirtci/blob/main/OWNERS)~~ [dhiller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment