search

kubevirt / kubevirtci

Contains cluster definitions and client tools to quickly spin up and destroy ephemeral and scalable k8s and ocp clusters for testing
Apache License 2.0
79 stars 119 forks source link

centos9: Add --numa support to vm.sh #1174

Closed lyarwood closed 4 months ago

lyarwood commented 4 months ago

What this PR does / why we need it:

This change adds basic support to the vm.sh script for defining a number of NUMA nodes per host with vCPUs and memory spread equally between them.

This change is broken out from the rest of the series wiring up gocli and cluster-up as it needs to be present in the current centos9 image to be testable in such a PR.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

See https://github.com/kubevirt/kubevirtci/pull/1171 for how this will be used.

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

NONE
kubevirt-bot commented 4 months ago

@lyarwood: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.27-vgpu d2ca1f2fb2a0f9958da803e4ec7137819cddf3bf link false /test check-up-kind-1.27-vgpu
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
lyarwood commented 4 months ago

/cc @vladikr /cc @brianmcarey

Hey folks, would you mind taking a look at this review and the wider series in https://github.com/kubevirt/kubevirtci/pull/1171, any and all comments welcome!

brianmcarey commented 4 months ago

/test ?

kubevirt-bot commented 4 months ago

@brianmcarey: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/kubevirt/kubevirtci/pull/1174#issuecomment-2066217100): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
brianmcarey commented 4 months ago

/test check-provision-centos-base

kubevirt-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirtci/blob/main/OWNERS)~~ [brianmcarey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lyarwood commented 4 months ago

/retest-required

vladikr commented 4 months ago

It looks good for me as well. Thanks @lyarwood ! /lgtm