kubevirt / kubevirtci

Contains cluster definitions and client tools to quickly spin up and destroy ephemeral and scalable k8s and ocp clusters for testing
Apache License 2.0
79 stars 119 forks source link

cluster-up, cnao: Do not deploy OVS-CNI #1184

Closed ormergi closed 3 months ago

ormergi commented 3 months ago

What this PR does / why we need it: There is no actual need to deploy OVS-CNI dy default at the moment, we dont test OVS CNI e2e in kubevirt/kubevirt.

Also the ephemeral cluster nodes does not have OVS back-end installed causing OVS-CNI pods to get into crush-loop all over CI.

In case OVS-CNI is required in certain environments, it can be deployed by patching the existing cluster-network-addons instance.

Set CNAO to not deploy OVS-CNI pods and reduce some memory consumption.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer: Other kubevirt org repositories that use kubevirt/kubevirtci for test/dev environment could patch CNAO NetworkAddonsConfig CR (NAC) and add the necessary components. Alternatively, set the environment variable KUBVIRT_WITH_CNAO_SKIP_CONFIG=true and deploy new NAC with all components that are necessary

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

cluster-up: CNAO does not deploy OVS-CNI by default
ormergi commented 3 months ago

/cc @EdDev

ormergi commented 3 months ago

Rebasesd

ormergi commented 3 months ago

/cc @phoracek

kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirtci/blob/main/OWNERS)~~ [brianmcarey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
brianmcarey commented 3 months ago

/test check-provision-k8s-1.29

kubevirt-commenter-bot commented 3 months ago

/retest-required This bot automatically retries required jobs that failed/flaked on approved PRs. Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

kubevirt-bot commented 3 months ago

@ormergi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.27-vgpu 9316d4128eb4358f3135eb8f7e64906efe5d2fab link false /test check-up-kind-1.27-vgpu
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
kubevirt-commenter-bot commented 3 months ago

/retest-required This bot automatically retries required jobs that failed/flaked on approved PRs. Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

oshoval commented 1 month ago

Added it to the bump script so this change wont be overridden upon bumping https://github.com/kubevirt/kubevirtci/pull/1215/files#diff-a62a4a90160c0961988d25e478dc85642e5404173a3151b42afd8777e90308d1R61 thx