aerosouund
commented
3 months ago @xpivarc @alicefr @acardace
So over the past few days i have been thinking of what questions do we need to explore to begin with this ? Just to confirm, we are on the same page about how the individual files in each provisioner are going to be transformed each (or some of them) to a mini cli and this is the first step we agreed to execute and investigate some of the questions that come to mind and some of the potential suggestions i think for them is.
1- Which files will be transformed to go during the coding period ?
eventually the goal is to do it for all, however during the coding period i believe we should set a few ones to be the absolute essentials that will guide how the rest is rewritten later. as its more important to create the skeleton of how this refactor should look like and move the files one by one after this skeleton has been established. for that i recommend provision.sh and provision-k8s.sh and a single optional feature file for which i nominate istio (we can agree to pick another one)
2- The execution architecture
During our call i thought that the suggestion of having the gocli signal commands to be run on the node container via a webserver is a very nice idea. in which the node container will come prebuilt with all the mini clis we created (or bash scripts for the files that will be rewritten later) and these get run via a request made to the node container from the cli. in case we agree that this is the idea we will go with then agreeing on what the api looks like and the type of it (rpc, rest) and how its served (tcp, unix) is the next most important step
3- The build process for the container and the clis
I think the easiest and least complicated way is to have all the clis (and the webserver) being built as a part of the node container build script and all of them existing in it by default. but this takes away the power to edit a single one of them and having it copied to the container during execution via scp. if this is important to us then we need something more nuanced that will account for the difference between the different operating systems and cpu architectures the cli is being built vs run on. In my opinion its a tradeoff between flexibility and complexity
What i recommend as a few starting steps:
- transforming provision.sh into a go cli. because its a step that has no big questions associated with it.
- If we agree on the webserver idea then the next thing is to discuss how this server should look like and implement it
kubevirt-bot
Is your feature request related to a problem? Please describe:
To port over the bash code of go cli into reusable and extensible go code. This issue exists to be a centralized discussion place for the different topics that need discussed related to the project. and as an umbrella issue to avoid the creation of ones with similar goals
Describe the solution you'd like:
The removal of duplicated bash code in the repo and the existence of a structure that allows us to transform the scripts one by one into go. as well as removing the wrappers required for the
provisionandruncommands of the gocli.Additional context:
Related issues: