kind-ovn: Introduce new kind-ovn provider

oshoval commented 3 months ago

What this PR does / why we need it: Provider allows running kubevirt with ovn-k8s tests on CI.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

kubevirt-bot commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

oshoval commented 3 months ago

/test check-provision-manager

oshoval commented 3 months ago

Thanks for the help here @qinqon

oshoval commented 3 months ago

trying something, please dont review it yet trying the new image quay.io/kubevirtci/golang-legacy:v20240523-1a2c9b8 that should have the 3 lines (watches / opensssl) built in

oshoval commented 3 months ago

ready to review again please addressed comments, updated PR desc

using updated legacy image that set watches / install openssl already bumped OVN k8s to include the e2e tests that were merged

testing the changes on CI for kubevirtci and kubevirt https://github.com/kubevirt/project-infra/pull/3426 https://github.com/kubevirt/project-infra/pull/3430

note that on kubevirt we don't need export DOCKER_PREFIX=localhost:5000 anymore, as the provider writes the config file that kubevirt uses

oshoval commented 3 months ago

rebased, and amend commit msg

oshoval commented 3 months ago

addressed comments of @qinqon @brianmcarey thx

qinqon commented 3 months ago

/lgtm

maiqueb commented 3 months ago

/lgtm

From my limited understanding this looks OK. Tks.

oshoval commented 3 months ago

addressed comments

maiqueb commented 3 months ago

/lgtm

kubevirt-bot commented 3 months ago

@oshoval: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
check-up-kind-1.27-vgpu	a704136a986cb45566fc82b2a67dd2edbfc14ae5	link	false	`/test check-up-kind-1.27-vgpu`

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirtci/blob/main/OWNERS)~~ [brianmcarey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubevirt / kubevirtci

kind-ovn: Introduce new kind-ovn provider #1193