Closed oshoval closed 3 months ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
/test check-provision-manager
Thanks for the help here @qinqon
trying something, please dont review it yet trying the new image quay.io/kubevirtci/golang-legacy:v20240523-1a2c9b8 that should have the 3 lines (watches / opensssl) built in
ready to review again please addressed comments, updated PR desc
using updated legacy image that set watches / install openssl already bumped OVN k8s to include the e2e tests that were merged
testing the changes on CI for kubevirtci and kubevirt https://github.com/kubevirt/project-infra/pull/3426 https://github.com/kubevirt/project-infra/pull/3430
note that on kubevirt we don't need export DOCKER_PREFIX=localhost:5000
anymore,
as the provider writes the config file that kubevirt uses
rebased, and amend commit msg
addressed comments of @qinqon @brianmcarey thx
/lgtm
/lgtm
From my limited understanding this looks OK. Tks.
addressed comments
/lgtm
@oshoval: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
check-up-kind-1.27-vgpu | a704136a986cb45566fc82b2a67dd2edbfc14ae5 | link | false | /test check-up-kind-1.27-vgpu |
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: brianmcarey
The full list of commands accepted by this bot can be found here.
The pull request process is described here
What this PR does / why we need it: Provider allows running kubevirt with ovn-k8s tests on CI.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
Release note: