Open aerosouund opened 3 months ago
Hi @aerosouund. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test
in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all
.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign davidvossel for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/uncc /cc @alicefr @xpivarc
Since you folks were pinged on the issue, I suspect you have been talking to @aerosouund .
/uncc @davidvossel
/cc @acardace
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
📝 Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:
@aerosouund we only accept signed commits. You need to rework each of the commits to have proper signing.
@aerosouund on top of what Daniel said, please try to split the code in clean separated commits with some explanation. Even if this is a draft, it is, otherwise, difficult to review and understanding what you are doing.
@dhiller Of course, i am just keeping this as a pull request where you guys can just see the code. eventually i will clean up everything properly @alicefr will do
PR needs rebase.
What this PR does / why we need it:
Which issue(s) this PR fixes
https://github.com/kubevirt/kubevirtci/issues/1185
Checklist