kubevirt / kubevirtci

Contains cluster definitions and client tools to quickly spin up and destroy ephemeral and scalable k8s and ocp clusters for testing
Apache License 2.0
79 stars 119 forks source link

KubevirtCI rewrite draft #1195

Open aerosouund opened 3 months ago

aerosouund commented 3 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes

https://github.com/kubevirt/kubevirtci/issues/1185

Checklist

kubevirt-bot commented 3 months ago

Hi @aerosouund. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign davidvossel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubevirtci/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dhiller commented 2 months ago

/uncc /cc @alicefr @xpivarc

Since you folks were pinged on the issue, I suspect you have been talking to @aerosouund .

dhiller commented 2 months ago

/uncc @davidvossel

alicefr commented 2 months ago

/cc @acardace

dhiller commented 2 months ago

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.

📝 Please follow instructions in the contributing guide to update your commits with the DCO

Full details of the Developer Certificate of Origin can be found at developercertificate.org.

The list of commits missing DCO signoff:

@aerosouund we only accept signed commits. You need to rework each of the commits to have proper signing.

alicefr commented 2 months ago

@aerosouund on top of what Daniel said, please try to split the code in clean separated commits with some explanation. Even if this is a draft, it is, otherwise, difficult to review and understanding what you are doing.

aerosouund commented 2 months ago

@dhiller Of course, i am just keeping this as a pull request where you guys can just see the code. eventually i will clean up everything properly @alicefr will do

kubevirt-bot commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.