search

kubevirt / kubevirtci

Contains cluster definitions and client tools to quickly spin up and destroy ephemeral and scalable k8s and ocp clusters for testing
Apache License 2.0
79 stars 119 forks source link

Adding s390x arch support in k8s 1.28 provider #1201

Open chandramerla opened 2 months ago

chandramerla commented 2 months ago

What this PR does / why we need it: This PR enables kubernetes 1.28 provider to be s390x arch compatible in SLIM(=true) mode. This is one of the initial steps to enabling Kubevirt CI for s390x

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer: With these changes I've run all the steps in KUBEVIRTCI_LOCAL_TESTING.md guide to test provider in both x86 and s390x machines, with specific mention of some details as below:

  1. Have not tested with KSM and SWAP ON and keeping SLIM=true for s390x, as this initial PR is targeting to add support of s390x for 1.28 provider in slim mode.
  2. Tested make cluster-up on s390x with even in single stack mode
  3. Have tested make cluster-sync on x86 (with KUBEVIRT_CDI_DEPLOY=false as otherwise there is an error 'error when creating "..../uploadproxy-nodeport.yaml": namespaces "cdi" not found')
  4. make functests on x86 are failing locally with 'timer expired' errors, etc., after I resolve the issue mentioned following the workaround

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

NONE
kubevirt-bot commented 2 months ago

Hi @chandramerla. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign qinqon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubevirtci/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chandramerla commented 2 months ago

/test ?

kubevirt-bot commented 2 months ago

@chandramerla: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to [this](https://github.com/kubevirt/kubevirtci/pull/1201#issuecomment-2159906747): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
chandramerla commented 2 months ago

/cc @brianmcarey

chandramerla commented 2 months ago

/unassign @brianmcarey

chandramerla commented 2 months ago

/cc @brianmcarey

chandramerla commented 2 months ago

@ Reviewers: Happy to take you through the changes in a call if that helps. Please let me know. Thanks!

brianmcarey commented 2 months ago

/test check-provision-k8s-1.28

brianmcarey commented 1 month ago

/test check-provision-k8s-1.28

brianmcarey commented 1 month ago

/test ?

kubevirt-bot commented 1 month ago

@brianmcarey: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/kubevirt/kubevirtci/pull/1201#issuecomment-2191209858): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
brianmcarey commented 1 month ago

/test check-gocli /test check-provision-centos-base

kubevirt-bot commented 1 week ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.