Open chandramerla opened 2 months ago
Hi @chandramerla. Thanks for your PR.
PRs from untrusted users cannot be marked as trusted with /ok-to-test
in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all
.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign qinqon for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/test ?
@chandramerla: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test
message.
/cc @brianmcarey
/unassign @brianmcarey
/cc @brianmcarey
@ Reviewers: Happy to take you through the changes in a call if that helps. Please let me know. Thanks!
/test check-provision-k8s-1.28
/test check-provision-k8s-1.28
/test ?
@brianmcarey: The following commands are available to trigger required jobs:
/test check-provision-alpine-with-test-tooling
/test check-provision-centos-base
/test check-provision-k8s-1.28
/test check-provision-k8s-1.29
/test check-provision-k8s-1.30
/test check-provision-manager
/test check-up-kind-ovn
/test check-up-kind-sriov
The following commands are available to trigger optional jobs:
/test check-gocli
/test check-up-kind-1.27-vgpu
Use /test all
to run the following jobs that were automatically triggered:
check-provision-alpine-with-test-tooling
check-provision-k8s-1.28
check-provision-k8s-1.29
check-provision-k8s-1.30
check-provision-manager
check-up-kind-1.27-vgpu
check-up-kind-sriov
/test check-gocli /test check-provision-centos-base
PR needs rebase.
What this PR does / why we need it: This PR enables kubernetes 1.28 provider to be s390x arch compatible in SLIM(=true) mode. This is one of the initial steps to enabling Kubevirt CI for s390x
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer: With these changes I've run all the steps in
KUBEVIRTCI_LOCAL_TESTING.md
guide to test provider in both x86 and s390x machines, with specific mention of some details as below:SLIM=true
for s390x, as this initial PR is targeting to add support of s390x for 1.28 provider in slim mode.make cluster-up
on s390x with even in single stack modemake cluster-sync
on x86 (with KUBEVIRT_CDI_DEPLOY=false as otherwise there is an error 'error when creating "..../uploadproxy-nodeport.yaml": namespaces "cdi" not found')Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
Release note: