Add option to provision 1Gi hugepages

acardace commented 2 months ago

What this PR does / why we need it: This is useful to test scenarios where you specifically need 1Gi hugepages VMs, such a case is when testing memory hotplug (virtio-mem) and 1Gi hugepages support.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

Add option to provision 1Gi hugepages

acardace commented 2 months ago

/cc @brianmcarey

kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirtci/blob/main/OWNERS)~~ [brianmcarey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

brianmcarey commented 2 months ago

/hold

@acardace - can you just add some details as to why we need this addition?

acardace commented 2 months ago

/hold

@acardace - can you just add some details as to why we need this addition?

I've updated the PR description, let me know if you need more details.

brianmcarey commented 2 months ago

Look good - thanks.

/hold cancel