Closed acardace closed 2 months ago
/cc @brianmcarey
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: brianmcarey
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/hold
@acardace - can you just add some details as to why we need this addition?
/hold
@acardace - can you just add some details as to why we need this addition?
I've updated the PR description, let me know if you need more details.
Look good - thanks.
/hold cancel
/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel
or /hold
comment for consistent failures.
/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel
or /hold
comment for consistent failures.
/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel
or /hold
comment for consistent failures.
/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel
or /hold
comment for consistent failures.
/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel
or /hold
comment for consistent failures.
@acardace: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
check-up-kind-1.27-vgpu | 3d3dd2b0a859339b200e03e5eb4783be02cbfc8e | link | false | /test check-up-kind-1.27-vgpu |
What this PR does / why we need it: This is useful to test scenarios where you specifically need 1Gi hugepages VMs, such a case is when testing memory hotplug (virtio-mem) and 1Gi hugepages support.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
Release note: