Closed brianmcarey closed 2 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: xpivarc Once this PR has been reviewed and has the lgtm label, please ask for approval from brianmcarey. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here. Needs approval from an approver in each of these files:
* **[OWNERS](https://github.com/kubevirt/kubevirtci/blob/main/OWNERS)**
Approvers can indicate their approval by writing
/approve
in a comment Approvers can cancel approval by writing/approve cancel
in a comment
@brianmcarey asking you for approve as prow suggest :)
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: brianmcarey, xpivarc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel
or /hold
comment for consistent failures.
/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel
or /hold
comment for consistent failures.
@brianmcarey: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
check-up-kind-1.27-vgpu | 78a661de79b16af79b4cfa6341ac644c3d78fcb0 | link | false | /test check-up-kind-1.27-vgpu |
/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel
or /hold
comment for consistent failures.
What this PR does / why we need it:
The publish of the centos base has been broken[1] since the move from
skopeo copy
topodman push
[2].The image needs to have the correct tag before it can be pushed.
[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-kubevirtci-bump-centos-base/1802914304081530880 [2] https://github.com/kubevirt/kubevirtci/pull/1200
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer:
/cc @xpivarc @dhiller
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
Release note: