search

kubevirt / kubevirtci

Contains cluster definitions and client tools to quickly spin up and destroy ephemeral and scalable k8s and ocp clusters for testing
Apache License 2.0
79 stars 119 forks source link

enable vm-image-builder for s390x. #1207

Closed vamsikrishna-siddu closed 1 month ago

vamsikrishna-siddu commented 2 months ago

Currently the fedora-test-tooling and fedora-Realtime images are used in e2e testing. I want to add the s390x support for these images. So that we can enable kubevirt e2e testing for s390x.
The alpine cloud-init is not supported for s390x as this https://[raw.githubusercontent.com/alpinelinux/alpine-make-vm-image/master/alpine-make-vm-image](https://raw.githubusercontent.com/alpinelinux/alpine-make-vm-image/master/alpine-make-vm-image) is not supported on s390x. I have also raised the issue https://github.com/alpinelinux/alpine-make-vm-image/issues/43 but there is no response on this yet

vamsikrishna-siddu commented 2 months ago

/cc @brianmcarey

kubevirt-bot commented 2 months ago

@vamsikrishna-siddu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.27-vgpu 1ce2923c6279f491aef6b175ee11a2f8c9626de2 link false /test check-up-kind-1.27-vgpu
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ormergi commented 2 months ago

@vamsikrishna-siddu Hi, thanks for the PR, note that to e2e test s390x arch you will probably need a cluster with s390x nodes. Are you going to test it on kubevirt CI? Is there e2e test for s390x already? if not, which repo will accommodate them?

vamsikrishna-siddu commented 2 months ago

@vamsikrishna-siddu Hi, thanks for the PR, note that to e2e test s390x arch you will probably need a cluster with s390x nodes. Are you going to test it on kubevirt CI? Is there e2e test for s390x already? if not, which repo will accommodate them?

Hi @ormergi at present there is no e2e test for s390x in the upstream. We are currently working on to enable e2e testing on s390x. We currently have a s390x k8s cluster on IBM Cloud that was added to the Kubevirt workloads. We are also planning to leverage kubevirtCI to run e2e tests. I have seen these images i.e. fedora-test-tooling etc. in e2e tests. So, I thought to enable them for s390x so that it will help in the e2e testing.

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[cluster-provision/images/vm-image-builder/OWNERS](https://github.com/kubevirt/kubevirtci/blob/main/cluster-provision/images/vm-image-builder/OWNERS)~~ [brianmcarey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
brianmcarey commented 1 month ago

@vamsikrishna-siddu - heres the resulting image quay.io/kubevirtci/fedora-with-test-tooling:v20240709-1ce2923