Library based ssh - Githubissues

aerosouund commented 1 month ago

What this PR does / why we need it: Replaces ssh.sh in run.go with golang library based ssh that goes directly to the node rather than the node container as a middle man

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

[ ] Design: A design document was considered and is present (link) or not required
[x] PR: The PR description is expressive enough and will help future contributors
[x] Code: Write code that humans can understand and Keep it simple
[x] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

Use library based ssh in run.go

kubevirt-bot commented 1 month ago

Hi @aerosouund. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

aerosouund commented 1 month ago

@xpivarc @brianmcarey @dhiller

xpivarc commented 1 month ago

@dhiller @brianmcarey Can you help me merge this one (missing approver right on this repo :) )

brianmcarey commented 1 month ago

/cc

xpivarc commented 1 month ago

/lgtm

acardace commented 1 month ago

/lgtm

dhiller commented 1 month ago

/test check-provision-k8s-1.28

dhiller commented 1 month ago

/test check-provision-k8s-1.30

dhiller commented 1 month ago

/lgtm

brianmcarey commented 1 month ago

/test ?

kubevirt-bot commented 1 month ago

@brianmcarey: The following commands are available to trigger required jobs:

/test check-provision-alpine-with-test-tooling
/test check-provision-centos-base
/test check-provision-k8s-1.28
/test check-provision-k8s-1.29
/test check-provision-k8s-1.30
/test check-provision-manager
/test check-up-kind-ovn
/test check-up-kind-sriov

The following commands are available to trigger optional jobs:

/test check-gocli
/test check-up-kind-1.27-vgpu
/test check-up-kind-1.30-vgpu

Use /test all to run the following jobs that were automatically triggered:

check-provision-alpine-with-test-tooling
check-provision-k8s-1.28
check-provision-k8s-1.29
check-provision-k8s-1.30
check-provision-manager
check-up-kind-1.27-vgpu
check-up-kind-1.30-vgpu
check-up-kind-sriov

In response to [this](https://github.com/kubevirt/kubevirtci/pull/1209#issuecomment-2228063290): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

brianmcarey commented 1 month ago

/test check-gocli /test check-provision-centos-base

kubevirt-bot commented 1 month ago

@aerosouund: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
check-up-kind-1.27-vgpu	1c993f7ee94a13d2254d81b119edd9bc68e8a693	link	false	`/test check-up-kind-1.27-vgpu`

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey, dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirtci/blob/main/OWNERS)~~ [brianmcarey,dhiller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

brianmcarey commented 1 month ago

/override check-provision-alpine-with-test-tooling

Not related to these changes.

kubevirt-bot commented 1 month ago

@brianmcarey: Overrode contexts on behalf of brianmcarey: check-provision-alpine-with-test-tooling

In response to [this](https://github.com/kubevirt/kubevirtci/pull/1209#issuecomment-2230131440): >/override check-provision-alpine-with-test-tooling > >Not related to these changes. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

kubevirt / kubevirtci

Library based ssh #1209