Opts package - Githubissues

aerosouund commented 2 months ago

What this PR does / why we need it:

Replace all bash script calls in the run command with the golang native opts package

Part of: #1110

Special Notes This branch is based off library-based-ssh. PR: #1209 it introduces the same commits but after library based ssh gets merged it will only introduce commits of the opts package

Checklist

[ ] Design: A design document was considered and is present (link) or not required
[x] PR: The PR description is expressive enough and will help future contributors
[x] Code: Write code that humans can understand and Keep it simple
[x] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[x] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

Move bash scripts to the gocli

aerosouund commented 3 weeks ago

@dhiller apologies, i pushed code to address this and didn't see you requested a test

please rerequest

dhiller commented 3 weeks ago

/test all

kubevirt-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller, xpivarc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirtci/blob/main/OWNERS)~~ [dhiller,xpivarc] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

dhiller commented 3 weeks ago

/test check-provision-k8s-1.29 /test check-provision-k8s-1.30 /test check-provision-k8s-1.31

dhiller commented 3 weeks ago

/unhold

xpivarc commented 3 weeks ago

/lgtm

kubevirt-bot commented 3 weeks ago

@aerosouund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
check-up-kind-1.30-vgpu	6fae0987ec998e9f1fb47c9dd201fa3c5b3aba1c	link	false	`/test check-up-kind-1.30-vgpu`
check-up-kind-1.27-vgpu	6fae0987ec998e9f1fb47c9dd201fa3c5b3aba1c	link	false	`/test check-up-kind-1.27-vgpu`

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

kubevirt-commenter-bot commented 2 weeks ago

/retest-required This bot automatically retries required jobs that failed/flaked on approved PRs. Silence the bot with an /lgtm cancel or /hold comment for consistent failures.