Closed aerosouund closed 2 weeks ago
@dhiller apologies, i pushed code to address this and didn't see you requested a test
please rerequest
/test all
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dhiller, xpivarc
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/test check-provision-k8s-1.29 /test check-provision-k8s-1.30 /test check-provision-k8s-1.31
/unhold
/lgtm
@aerosouund: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
check-up-kind-1.30-vgpu | 6fae0987ec998e9f1fb47c9dd201fa3c5b3aba1c | link | false | /test check-up-kind-1.30-vgpu |
check-up-kind-1.27-vgpu | 6fae0987ec998e9f1fb47c9dd201fa3c5b3aba1c | link | false | /test check-up-kind-1.27-vgpu |
/retest-required
This bot automatically retries required jobs that failed/flaked on approved PRs.
Silence the bot with an /lgtm cancel
or /hold
comment for consistent failures.
It looks like we are hitting issues with cluster-up since this PR was merged - https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/12677/pull-kubevirt-e2e-k8s-1.29-sig-storage/1828330116103540736#1:build-log.txt%3A327
@brianmcarey this is fixed in #1255 please take a look at it
this is concerning the issue with the storage lane, for the others is this a flake or also related to this PR ?
we also added #1253 for quicker detection of such issues in the future, this script is meant to run as a CI lane on kubevirt CI
@brianmcarey: https://github.com/kubevirt/kubevirtci/pull/1258 here's the fix :)
@aerosouund - there looks to be some issue with the istio deployment that is being picked up by the network lanes on the bump kubevirtci PR - https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/12677/pull-kubevirt-e2e-k8s-1.31-sig-network/1829308375628779520
checking
What this PR does / why we need it:
Replace all bash script calls in the run command with the golang native opts package
Part of: #1110
Special Notes This branch is based off
library-based-ssh
. PR: #1209 it introduces the same commits but after library based ssh gets merged it will only introduce commits of the opts packageChecklist
Release note: