kubevirt / kubevirtci

Contains cluster definitions and client tools to quickly spin up and destroy ephemeral and scalable k8s and ocp clusters for testing
Apache License 2.0
79 stars 119 forks source link

alpine,image: Use full image name for qemu-user-static image #1218

Closed brianmcarey closed 1 month ago

brianmcarey commented 1 month ago

What this PR does / why we need it:

Some tools like podman prefer to use full image names[1] - update the qemu-user-static image to use full name

[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirtci/1209/check-provision-alpine-with-test-tooling/1812792004837380096#1:build-log.txt%3A792

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

/cc @dhiller @xpivarc

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

kubevirt-bot commented 1 month ago

@brianmcarey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.27-vgpu e6e9f33139e080c4b19aa9cdd11a193a43b2e7fd link false /test check-up-kind-1.27-vgpu
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
brianmcarey commented 1 month ago

@dhiller @xpivarc - the short image name here is causing the publish job to fail - https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/publish-kubevirtci/1812779164818739200#1:build-log.txt%3A7053

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[cluster-provision/images/vm-image-builder/OWNERS](https://github.com/kubevirt/kubevirtci/blob/main/cluster-provision/images/vm-image-builder/OWNERS)~~ [dhiller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment