search

kubevirt / kubevirtci

Contains cluster definitions and client tools to quickly spin up and destroy ephemeral and scalable k8s and ocp clusters for testing
Apache License 2.0
79 stars 118 forks source link

K8s 1.30 provider slim s390x #1252

Open chandramerla opened 3 weeks ago

chandramerla commented 3 weeks ago

What this PR does / why we need it: Enables s390x support in kubernetes provider 1.30. This is required for running s390x based tests spinning a k8s cluster using k8s provider.

Special notes for your reviewer: Earlier PR (created for 1.28 provider) whose comments are addressed in this PR: #1201 Changes required in respective prow jobs to publish provider are in PR: #3566

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

NONE
kubevirt-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign rmohr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubevirtci/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 3 weeks ago

Hi @chandramerla. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dhiller commented 3 weeks ago

/cc

chandramerla commented 3 weeks ago

I've run publish.sh inside the containers used in kubevirtci prow jobs, which build and publish gocli, centos9, k8s provider images and alpine container image. With the changes in publish.sh script in this PR and prow job related changes (In PR https://github.com/kubevirt/project-infra/pull/3566), I've successfully tested publishing of multiarch manifest-list for all the above images to icr.io (as I don't have write access in quay.io). In published multiarch manifest-lists s390x arch based images are built/present for gocli, centos9 and k8s-1.30 (slim).

chandramerla commented 3 weeks ago

/sig ci

brianmcarey commented 2 weeks ago

/test ?

kubevirt-bot commented 2 weeks ago

@brianmcarey: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/kubevirt/kubevirtci/pull/1252#issuecomment-2317070562): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
brianmcarey commented 2 weeks ago

/test check-provision-k8s-1.30 /test check-gocli

chandramerla commented 4 days ago

@brianmcarey : Could you rerun tests and review this?

brianmcarey commented 1 day ago

/test check-provision-k8s-1.30 /test check-gocli

brianmcarey commented 14 hours ago

/test check-provision-k8s-1.30