kubevirt / kubevirtci

Contains cluster definitions and client tools to quickly spin up and destroy ephemeral and scalable k8s and ocp clusters for testing
Apache License 2.0
79 stars 118 forks source link

Libssh in provision #1261

Open aerosouund opened 2 weeks ago

aerosouund commented 2 weeks ago

What this PR does / why we need it:

Removes occurrences of ssh.sh from the provision command in the gocli, this should have the benefit of ending the timeout during shutdown flake since ssh connection is made directly to the VM without an intermediary

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

Use libssh in provision cmd
kubevirt-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign enp0s3 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/kubevirtci/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
aerosouund commented 2 weeks ago

cc: @dhiller This introduces the fix i mentioned in the last meeting

aerosouund commented 2 weeks ago

/test all

kubevirt-bot commented 6 days ago

@aerosouund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.27-vgpu d5c30573bc24c66801c5a08a280cb37171156bd1 link false /test check-up-kind-1.27-vgpu
check-up-kind-1.30-vgpu d5c30573bc24c66801c5a08a280cb37171156bd1 link false /test check-up-kind-1.30-vgpu
check-provision-k8s-1.31 d5c30573bc24c66801c5a08a280cb37171156bd1 link true /test check-provision-k8s-1.31
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).