kubevirt / kubevirtci

Contains cluster definitions and client tools to quickly spin up and destroy ephemeral and scalable k8s and ocp clusters for testing
Apache License 2.0
82 stars 119 forks source link

Label rook storage class #1267

Closed aerosouund closed 1 month ago

aerosouund commented 1 month ago

What this PR does / why we need it:

Fixes the problem mentioned with ceph storage class labeling in: https://github.com/kubevirt/kubevirt/pull/12677#issuecomment-2336737660

By executing the patch commands through the sshClient and adds the expected calls to the test suites of ceph and run

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

The fix uses kubectl and bash to avoid modifying the k8s client interface before deploying the fix, another PR that will introduce a Patch method in the k8s client will follow shortly

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

aerosouund commented 1 month ago

cc: @xpivarc @brianmcarey @dhiller

kubevirt-bot commented 1 month ago

@aerosouund: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.27-vgpu 8623467419437b20523f71de3fdaa94f390bf68b link false /test check-up-kind-1.27-vgpu
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
brianmcarey commented 1 month ago

/cc @akalenyu

akalenyu commented 1 month ago

/lgtm thank you!

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/kubevirtci/blob/main/OWNERS)~~ [brianmcarey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment