Open dhiller opened 9 months ago
/area automation /area prow
/kind tracker
From the first round of testing I got these results:
image:
config specifically.Need to improve kubevirtci bump selection: https://github.com/kubevirt/kubevirt/pull/10747#issuecomment-1851616047
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close
.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen
.
Mark the issue as fresh with /remove-lifecycle rotten
.
/close
@kubevirt-bot: Closing this issue.
/reopen
We still want to do this.
@dhiller: Reopened this issue.
/remove-lifecycle rotten
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
botreview
aims to automate reviews that follow simple patterns.Motivation of this is to check automatically created PRs like image bumps, prow bumps, kubevirtci bumps etc., i.e. all PRs that follow simple patterns, are tedious to review but still required to check.
If anything beyond those patterns appears, it will backoff and add a comment with suspicious changes it found.
Note:
botreview
only acts as a first gate to filter out those PRs that really require a humans review!Roadmap
--dry-run
tofalse
and see how it goes, monitor the logs--dry-run=false
in project-infra deployment see how it goes, monitor the logskubevirt-review-bot
GitHub service accountHow to run
It can be run in two ways:
as a command
Example run:
If
--dry-run=false
is set, it will attach a comment to the review that states the review result.Result: https://github.com/kubevirt/project-infra/pull/2485#issuecomment-1327188198
Note: using
--dry-run=true
or omitting the flag will run the tool in dry-run which will just print out the result)as an external plugin for prow
It will react on pull request events for the repos it's configured for in the plugins config and will review simple PRs automatically.
Note that the deployment currently has
`--dry-run=true
enabled, since we want to test it's stability gradually.Review strategies
Review strategies implemented today:
Note: It can also handle mixed PRs, where each change abides by the rules of the strategy.
[^1]: required since kubevirt-bot can't
lgtm
their own PRs