New release branch presubmits are missing `run_before_merge: true`

kubevirt / project-infra

Project infrastructure administrative tools

Apache License 2.0

25 stars 126 forks source link

New release branch presubmits are missing `run_before_merge: true` #3478

Open brianmcarey opened 3 weeks ago

brianmcarey commented 3 weeks ago

This field was added to the main branch presubmit jobs to enable use of the phased plugin - the phased plugin does not target release branches and the run_before_merge field is missing from the recent v1.3 presubmit job config[1].

This issue can cause backport PRs to merge without having the full suite of CI test lanes run successfully[2].

[1] https://github.com/kubevirt/project-infra/pull/3477 [2] https://prow.ci.kubevirt.io/pr-history/?org=kubevirt&repo=kubevirt&pr=12132

brianmcarey commented 3 weeks ago

cc @oshoval @dhiller

oshoval commented 3 weeks ago

Thanks

We can either take this PR https://github.com/kubevirt/project-infra/pull/3126 - imo it is the best do those manually upon forking (change to always_run = true), or add the run_before_merge or upgrade prow utils so they will have the new field in the struct (but for that Bazel did problems) we can also introduce dummy struct with the new field inline and use it

supporting phased on branches wont help because we do need run_before_merge and to consider branch protection (unless we develop phased plugin deeper to not miss events and so on)

dhiller commented 3 weeks ago

FYI @xpivarc

We need to take that into account next release at the latest!