kubevirt / project-infra

Project infrastructure administrative tools
Apache License 2.0
25 stars 130 forks source link

Add virt-api and virt-controller resource utilization to benchmarks #3487

Closed Sreeja1725 closed 1 month ago

Sreeja1725 commented 1 month ago

What this PR does / why we need it:

Make virt-api and virt-controller resource utilization metrics to benchmarks available in the graphs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #3486 Complements https://github.com/kubevirt/kubevirt/pull/12116

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

Add virt-api and virt-controller resource utilization to benchmarks
kubevirt-bot commented 1 month ago

Hi @Sreeja1725. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
Sreeja1725 commented 1 month ago

/cc @alaypatel07

alaypatel07 commented 1 month ago

/assign @rthallisey for approval

kubevirt-bot commented 1 month ago

@alaypatel07: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubevirt members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubevirt/project-infra/pull/3487#issuecomment-2192240400): >/assign @rthallisey for approval Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
alaypatel07 commented 1 month ago

/lgtm /approve

rthallisey commented 1 month ago

/approve

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alaypatel07, rthallisey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[robots/cmd/perf-report-creator/OWNERS](https://github.com/kubevirt/project-infra/blob/main/robots/cmd/perf-report-creator/OWNERS)~~ [rthallisey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment