Closed oshoval closed 1 month ago
/cc @dhiller @maiqueb @qinqon
Thanks
is it a must to add OWNERS file to the new repo ? asking because on KubeSecondaryDNS i saw it was populated to
however we don't have presubmit on prow for the new component, we are using git actions so not sure its needed (unless it is needed for other standard)
/lgtm /approve
{"component":"peribolos","error":"failed to list ipam-extensions(ipam-extensions) members: return code not 2XX: 404 Not Found","level":"warning","msg":"failed to update ipam-extensions members: failed to list ipam-extensions(ipam-extensions) members: return code not 2XX: 404 Not Found","severity":"warning","time":"2024-06-26T08:43:27Z"}
maybe because OWNERS file is needed? or because they need to be defined somewhere else
{"component":"peribolos","error":"failed to list ipam-extensions(ipam-extensions) members: return code not 2XX: 404 Not Found","level":"warning","msg":"failed to update ipam-extensions members: failed to list ipam-extensions(ipam-extensions) members: return code not 2XX: 404 Not Found","severity":"warning","time":"2024-06-26T08:43:27Z"}
maybe because OWNERS file is needed? or because they need to be defined somewhere else
No, that's just because the team doesn't exist yet - a misconfiguration on the peribolos checks.
I'll take a look at the PR now.
Thanks !
@dhiller: Overrode contexts on behalf of dhiller: pull-kubevirt-org-github-config-updater
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dhiller, qinqon
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@oshoval: Updated the following 2 configmaps:
plugins
configmap in namespace kubevirt-prow
at cluster default
using the following files:
plugins.yaml
using file github/ci/prow-deploy/kustom/base/configs/current/plugins/plugins.yaml
config
configmap in namespace kubevirt-prow
at cluster default
using the following files:
config.yaml
using file github/ci/prow-deploy/kustom/base/configs/current/config/config.yaml
Thanks @qinqon @dhiller
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
Release note: