search

kubevirt / project-infra

Project infrastructure administrative tools
Apache License 2.0
25 stars 130 forks source link

prow: Add ipam-extensions basic config #3492

Closed oshoval closed 1 month ago

oshoval commented 1 month ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

oshoval commented 1 month ago

/cc @dhiller @maiqueb @qinqon

Thanks

oshoval commented 1 month ago

is it a must to add OWNERS file to the new repo ? asking because on KubeSecondaryDNS i saw it was populated to

https://github.com/kubevirt/project-infra/blob/main/github/ci/prow-deploy/files/jobs/kubevirt/kubesecondarydns/OWNERS

however we don't have presubmit on prow for the new component, we are using git actions so not sure its needed (unless it is needed for other standard)

qinqon commented 1 month ago

/lgtm /approve

oshoval commented 1 month ago

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3492/pull-kubevirt-org-github-config-updater/1805867032248324096

{"component":"peribolos","error":"failed to list ipam-extensions(ipam-extensions) members: return code not 2XX: 404 Not Found","level":"warning","msg":"failed to update ipam-extensions members: failed to list ipam-extensions(ipam-extensions) members: return code not 2XX: 404 Not Found","severity":"warning","time":"2024-06-26T08:43:27Z"}

maybe because OWNERS file is needed? or because they need to be defined somewhere else

dhiller commented 1 month ago

prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3492/pull-kubevirt-org-github-config-updater/1805867032248324096

{"component":"peribolos","error":"failed to list ipam-extensions(ipam-extensions) members: return code not 2XX: 404 Not Found","level":"warning","msg":"failed to update ipam-extensions members: failed to list ipam-extensions(ipam-extensions) members: return code not 2XX: 404 Not Found","severity":"warning","time":"2024-06-26T08:43:27Z"}

maybe because OWNERS file is needed? or because they need to be defined somewhere else

No, that's just because the team doesn't exist yet - a misconfiguration on the peribolos checks.

I'll take a look at the PR now.

oshoval commented 1 month ago

Thanks !

kubevirt-bot commented 1 month ago

@dhiller: Overrode contexts on behalf of dhiller: pull-kubevirt-org-github-config-updater

In response to [this](https://github.com/kubevirt/project-infra/pull/3492#pullrequestreview-2141170257): >/override pull-kubevirt-org-github-config-updater > >As said, the team doesn't exist yet, which is making the presubmit fail. > >/approve > >One nit inline. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/project-infra/blob/main/OWNERS)~~ [dhiller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 1 month ago

@oshoval: Updated the following 2 configmaps:

In response to [this](https://github.com/kubevirt/project-infra/pull/3492): > > >**What this PR does / why we need it**: > >**Which issue(s) this PR fixes** *(optional, in `fixes #(, fixes #, ...)` format, will close the issue(s) when PR gets merged)*: >Fixes # > >**Special notes for your reviewer**: > >**Checklist** > >This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. >Approvers are expected to review this list. > >- [ ] Design: A [design document](https://github.com/kubevirt/community/tree/main/design-proposals) was considered and is present (link) or not required >- [ ] PR: The PR description is expressive enough and will help future contributors >- [ ] Code: [Write code that humans can understand](https://en.wikiquote.org/wiki/Martin_Fowler#code-for-humans) and [Keep it simple](https://en.wikipedia.org/wiki/KISS_principle) >- [ ] Refactor: You have [left the code cleaner than you found it (Boy Scout Rule)](https://learning.oreilly.com/library/view/97-things-every/9780596809515/ch08.html) >- [ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required >- [ ] Testing: New code requires [new unit tests](https://github.com/kubevirt/kubevirt/blob/main/docs/reviewer-guide.md#when-is-a-pr-good-enough). New features and bug fixes require at least on e2e test >- [ ] Documentation: A [user-guide update](https://github.com/kubevirt/user-guide/) was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change. >- [ ] Community: Announcement to [kubevirt-dev](https://groups.google.com/g/kubevirt-dev/) was considered > >**Release note**: > >```release-note > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
oshoval commented 1 month ago

Thanks @qinqon @dhiller