search

kubevirt / project-infra

Project infrastructure administrative tools
Apache License 2.0
25 stars 130 forks source link

Enable NodeRestriction fg for 1.30 lanes #3495

Closed xpivarc closed 1 month ago

xpivarc commented 1 month ago

What this PR does / why we need it: Enable NodeRestriction fg for 1.30 lanes This allow us to get wider feedback on the feature.

Ref https://github.com/kubevirt/kubevirt/pull/12009

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

NONE
xpivarc commented 1 month ago

/cc @dhiller @brianmcarey

brianmcarey commented 1 month ago

/rehearse

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.30-sig-compute-migrations
rehearsal-pull-kubevirt-e2e-k8s-1.30-sig-compute-serial
rehearsal-pull-kubevirt-e2e-k8s-1.30-sig-storage
rehearsal-pull-kubevirt-e2e-k8s-1.30-sig-compute
rehearsal-pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network
rehearsal-pull-kubevirt-e2e-k8s-1.30-sig-network
rehearsal-pull-kubevirt-e2e-k8s-1.30-sig-operator

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller commented 1 month ago

I don't see an effect on tests requiring this feature gate being executed - likely the fg ServiceAccountTokenPodNodeInfo needs to get enabled as documented in KV source - I don't know whether that has happened inside KubeVirtCI?

dhiller commented 1 month ago

^^ @xpivarc

xpivarc commented 1 month ago

I don't see an effect on tests requiring this feature gate being executed - likely the fg ServiceAccountTokenPodNodeInfo needs to get enabled as documented in KV source - I don't know whether that has happened inside KubeVirtCI?

1.30 lanes has this by default because it is in Beta there.

xpivarc commented 1 month ago

ping @dhiller @brianmcarey

brianmcarey commented 1 month ago

/rehearse

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

rehearsal-pull-kubevirt-e2e-k8s-1.30-sig-compute
rehearsal-pull-kubevirt-e2e-k8s-1.30-ipv6-sig-network
rehearsal-pull-kubevirt-e2e-k8s-1.30-sig-compute-migrations
rehearsal-pull-kubevirt-e2e-k8s-1.30-sig-compute-serial
rehearsal-pull-kubevirt-e2e-k8s-1.30-sig-network
rehearsal-pull-kubevirt-e2e-k8s-1.30-sig-storage
rehearsal-pull-kubevirt-e2e-k8s-1.30-sig-operator

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/OWNERS](https://github.com/kubevirt/project-infra/blob/main/github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/OWNERS)~~ [brianmcarey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
brianmcarey commented 1 month ago

/hold cancel

kubevirt-bot commented 1 month ago

@xpivarc: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

In response to [this](https://github.com/kubevirt/project-infra/pull/3495): >**What this PR does / why we need it**: >Enable NodeRestriction fg for 1.30 lanes >This allow us to get wider feedback on the >feature. > >Ref https://github.com/kubevirt/kubevirt/pull/12009 > >**Which issue(s) this PR fixes** *(optional, in `fixes #(, fixes #, ...)` format, will close the issue(s) when PR gets merged)*: >Fixes # > >**Special notes for your reviewer**: > >**Release note**: > >```release-note >NONE >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.