search

kubevirt / project-infra

Project infrastructure administrative tools
Apache License 2.0
25 stars 130 forks source link

add cluster-sync periodic job for s390x. #3501

Open vamsikrishna-siddu opened 1 month ago

vamsikrishna-siddu commented 1 month ago

Hi @brianmcarey
I have tested this in my local and this test is passing. Can you please take a look at it when you get some time and let me know your thoughts?

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign iholder101 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/OWNERS](https://github.com/kubevirt/project-infra/blob/main/github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vamsikrishna-siddu commented 1 month ago

/cc @brianmcarey

vamsikrishna-siddu commented 3 weeks ago

/retest

brianmcarey commented 3 weeks ago

@vamsikrishna-siddu does this need to be converted back to a periodic test lane or do you want to add it as a presubmit test lane?

vamsikrishna-siddu commented 3 weeks ago

@vamsikrishna-siddu does this need to be converted back to a periodic test lane or do you want to add it as a presubmit test lane?

Hi @brianmcarey I want to add it as a presubmit test lane

brianmcarey commented 3 weeks ago

@vamsikrishna-siddu does this need to be converted back to a periodic test lane or do you want to add it as a presubmit test lane?

Hi @brianmcarey I want to add it as a presubmit test lane

As this job is using some sensitive secrets - I would prefer to run this as a periodic - maybe 4 times a day to get some good coverage?

vamsikrishna-siddu commented 3 weeks ago

@vamsikrishna-siddu does this need to be converted back to a periodic test lane or do you want to add it as a presubmit test lane?

Hi @brianmcarey I want to add it as a presubmit test lane

As this job is using some sensitive secrets - I would prefer to run this as a periodic - maybe 4 times a day to get some good coverage?

sure @brianmcarey