Open vamsikrishna-siddu opened 1 month ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign iholder101 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/cc @brianmcarey
/retest
@vamsikrishna-siddu does this need to be converted back to a periodic test lane or do you want to add it as a presubmit test lane?
@vamsikrishna-siddu does this need to be converted back to a periodic test lane or do you want to add it as a presubmit test lane?
Hi @brianmcarey I want to add it as a presubmit test lane
@vamsikrishna-siddu does this need to be converted back to a periodic test lane or do you want to add it as a presubmit test lane?
Hi @brianmcarey I want to add it as a presubmit test lane
As this job is using some sensitive secrets - I would prefer to run this as a periodic - maybe 4 times a day to get some good coverage?
@vamsikrishna-siddu does this need to be converted back to a periodic test lane or do you want to add it as a presubmit test lane?
Hi @brianmcarey I want to add it as a presubmit test lane
As this job is using some sensitive secrets - I would prefer to run this as a periodic - maybe 4 times a day to get some good coverage?
sure @brianmcarey
Hi @brianmcarey
I have tested this in my local and this test is passing. Can you please take a look at it when you get some time and let me know your thoughts?