kubevirt / project-infra

Project infrastructure administrative tools
Apache License 2.0
25 stars 130 forks source link

fix(common-instancetypes): Set COMMON_INSTANCETYPES_CRI #3503

Closed 0xFelix closed 1 month ago

0xFelix commented 1 month ago

What this PR does / why we need it:

Set COMMON_INSTANCETYPES_CRI in pull-common-instancetypes to empty to avoid using the non-present podman as CRI. Also make pull-common-instancetypes not optional anymore.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

None
kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from 0xfelix. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[github/ci/prow-deploy/files/jobs/kubevirt/common-instancetypes/OWNERS](https://github.com/kubevirt/project-infra/blob/main/github/ci/prow-deploy/files/jobs/kubevirt/common-instancetypes/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
0xFelix commented 1 month ago

/rehearse ?

kubevirt-bot commented 1 month ago

Rehearsal is available for the following jobs in this PR:

pull-common-instancetypes

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

0xFelix commented 1 month ago

/rehearse pull-common-instancetypes

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

rehearsal-pull-common-instancetypes

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

kubevirt-bot commented 1 month ago

@0xFelix: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
rehearsal-pull-common-instancetypes 95feed1f7dad211eb9ed6eaedeb798c9f159cbbc link unknown /test pull-common-instancetypes
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).