Closed 0xFelix closed 1 month ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from 0xfelix. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/rehearse ?
Rehearsal is available for the following jobs in this PR:
pull-common-instancetypes
You can trigger rehearsal for all jobs by commenting either /rehearse
or /rehearse all
on this PR.
For a specific PR you can comment /rehearse {job-name}
.
For a list of jobs that you can rehearse you can comment /rehearse ?
.
/rehearse pull-common-instancetypes
Rehearsal jobs created for this PR:
rehearsal-pull-common-instancetypes
You can trigger rehearsal for all jobs by commenting either /rehearse
or /rehearse all
on this PR.
For a specific PR you can comment /rehearse {job-name}
.
For a list of jobs that you can rehearse you can comment /rehearse ?
.
@0xFelix: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
rehearsal-pull-common-instancetypes | 95feed1f7dad211eb9ed6eaedeb798c9f159cbbc | link | unknown | /test pull-common-instancetypes |
What this PR does / why we need it:
Set COMMON_INSTANCETYPES_CRI in pull-common-instancetypes to empty to avoid using the non-present podman as CRI. Also make pull-common-instancetypes not optional anymore.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
Release note: