search

kubevirt / project-infra

Project infrastructure administrative tools
Apache License 2.0
25 stars 130 forks source link

common-instancetypes: Add OpenSUSE Tumbleweed and Leap presubmits #3505

Closed lyarwood closed 1 month ago

lyarwood commented 1 month ago

/cc @0xFelix

What this PR does / why we need it:

$subject, will be used by https://github.com/kubevirt/common-instancetypes/pull/193

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

NONE
brianmcarey commented 1 month ago

/rehearse

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-tumbleweed
rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-leap

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

lyarwood commented 1 month ago

/rehearse

@brianmcarey thanks but this isn't going to run any tests until https://github.com/kubevirt/common-instancetypes/pull/193 lands.

lyarwood commented 1 month ago

/hold /rehearse all

Okay so https://github.com/kubevirt/common-instancetypes/pull/193 just merged so now we can rerun these.

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-tumbleweed
rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-leap

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

lyarwood commented 1 month ago

/hold cancel

@0xFelix @brianmcarey okay this should be good now, thanks!

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[github/ci/prow-deploy/files/jobs/kubevirt/common-instancetypes/OWNERS](https://github.com/kubevirt/project-infra/blob/main/github/ci/prow-deploy/files/jobs/kubevirt/common-instancetypes/OWNERS)~~ [brianmcarey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 1 month ago

@lyarwood: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

In response to [this](https://github.com/kubevirt/project-infra/pull/3505): >/cc @0xFelix > >**What this PR does / why we need it**: > >$subject, will be used by https://github.com/kubevirt/common-instancetypes/pull/193 > >**Which issue(s) this PR fixes** *(optional, in `fixes #(, fixes #, ...)` format, will close the issue(s) when PR gets merged)*: >Fixes # > >**Special notes for your reviewer**: > >**Checklist** > >This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. >Approvers are expected to review this list. > >- [ ] Design: A [design document](https://github.com/kubevirt/community/tree/main/design-proposals) was considered and is present (link) or not required >- [ ] PR: The PR description is expressive enough and will help future contributors >- [ ] Code: [Write code that humans can understand](https://en.wikiquote.org/wiki/Martin_Fowler#code-for-humans) and [Keep it simple](https://en.wikipedia.org/wiki/KISS_principle) >- [ ] Refactor: You have [left the code cleaner than you found it (Boy Scout Rule)](https://learning.oreilly.com/library/view/97-things-every/9780596809515/ch08.html) >- [ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required >- [ ] Testing: New code requires [new unit tests](https://github.com/kubevirt/kubevirt/blob/main/docs/reviewer-guide.md#when-is-a-pr-good-enough). New features and bug fixes require at least on e2e test >- [ ] Documentation: A [user-guide update](https://github.com/kubevirt/user-guide/) was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change. >- [ ] Community: Announcement to [kubevirt-dev](https://groups.google.com/g/kubevirt-dev/) was considered > >**Release note**: > >```release-note >NONE >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.