search

kubevirt / project-infra

Project infrastructure administrative tools
Apache License 2.0
25 stars 130 forks source link

project-infra, bazel: move presubmits to pure go #3508

Closed dhiller closed 1 month ago

dhiller commented 1 month ago

What this PR does / why we need it:

Adding to our effort to move away from bazel we are moving some presubmits towards pure go:

(the latter still uses bazel k8s gitops rules, which needs to get converted to kustomize and kubectl apply, but testing is done via go)

Along the way we fix an error wrt formatting placeholder mismatch.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

kubevirt-bot commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

dhiller commented 1 month ago

/rehearse ?

kubevirt-bot commented 1 month ago

Rehearsal is available for the following jobs in this PR:

pull-project-infra-test-robots

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller commented 1 month ago

/rehearse pull-project-infra-test-robots

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

rehearsal-pull-project-infra-test-robots

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller commented 1 month ago

/rehearse pull-project-infra-test-robots

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

rehearsal-pull-project-infra-test-robots

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller commented 1 month ago

/rehearse pull-project-infra-test-robots

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

rehearsal-pull-project-infra-test-robots

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller commented 1 month ago

/rehearse pull-project-infra-test-robots

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

rehearsal-pull-project-infra-test-robots

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller commented 1 month ago

/uncc @davidvossel @rmohr

dhiller commented 1 month ago

/rehearse pull-project-infra-test-robots

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

rehearsal-pull-project-infra-test-robots

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller commented 1 month ago

/rehearse pull-project-infra-test-robots

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

rehearsal-pull-project-infra-test-robots

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller commented 1 month ago

/rehearse pull-project-infra-ci-search-deploy-test

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

rehearsal-pull-project-infra-ci-search-deploy-test

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller commented 1 month ago

@brianmcarey since the ci-search deployment will take longer to convert (removing bazel requires converting the gitops k8s deploy to kustomize), I would suggest taking this in directly, so that we have that in already. WDYT?

dhiller commented 1 month ago

/uncc @vladikr @aglitke /cc @brianmcarey

dhiller commented 1 month ago

/rehearse

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

rehearsal-pull-project-infra-ci-search-deploy-test
rehearsal-pull-project-infra-test-external-plugins
rehearsal-pull-project-infra-test-releng
rehearsal-pull-project-infra-test-robots

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/project-infra/blob/main/OWNERS)~~ [brianmcarey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dhiller commented 1 month ago

We actually set it by default against all jobs.

https://github.com/kubevirt/project-infra/blob/30da4d3b044d4f2cb54150e498973f9f337a266f/github/ci/prow-deploy/kustom/base/configs/current/config/config.yaml#L685

Can you add why you are moving these jobs to go over bazel in the PR description?

Good point, I totally forgot that :blush: !

/lgtm /approve

/hold

/unhold

kubevirt-bot commented 1 month ago

@dhiller: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

In response to [this](https://github.com/kubevirt/project-infra/pull/3508): > > >**What this PR does / why we need it**: > >Adding to our effort to move away from bazel we are moving some presubmits towards pure go: > >* pull-project-infra-test-robots >* pull-project-infra-test-releng >* pull-project-infra-test-external-plugins >* pull-project-infra-ci-search-deploy-test > >(the latter still uses bazel k8s gitops rules, which needs to get converted to kustomize and kubectl apply, but testing is done via go) > >Along the way we fix an error wrt formatting placeholder mismatch. > >**Which issue(s) this PR fixes** *(optional, in `fixes #(, fixes #, ...)` format, will close the issue(s) when PR gets merged)*: >Fixes # > >**Special notes for your reviewer**: > >**Checklist** > >This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. >Approvers are expected to review this list. > >- [ ] Design: A [design document](https://github.com/kubevirt/community/tree/main/design-proposals) was considered and is present (link) or not required >- [ ] PR: The PR description is expressive enough and will help future contributors >- [ ] Code: [Write code that humans can understand](https://en.wikiquote.org/wiki/Martin_Fowler#code-for-humans) and [Keep it simple](https://en.wikipedia.org/wiki/KISS_principle) >- [ ] Refactor: You have [left the code cleaner than you found it (Boy Scout Rule)](https://learning.oreilly.com/library/view/97-things-every/9780596809515/ch08.html) >- [ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required >- [ ] Testing: New code requires [new unit tests](https://github.com/kubevirt/kubevirt/blob/main/docs/reviewer-guide.md#when-is-a-pr-good-enough). New features and bug fixes require at least on e2e test >- [ ] Documentation: A [user-guide update](https://github.com/kubevirt/user-guide/) was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change. >- [ ] Community: Announcement to [kubevirt-dev](https://groups.google.com/g/kubevirt-dev/) was considered > >**Release note**: > >```release-note > >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.