search

kubevirt / project-infra

Project infrastructure administrative tools
Apache License 2.0
25 stars 130 forks source link

chore: enable branch protection for kubevirt-tekton-tasks #3513

Closed ksimon1 closed 1 month ago

ksimon1 commented 1 month ago

What this PR does / why we need it: chore: enable branch protection for kubevirt-tekton-tasks

Release note:

NONE
ksimon1 commented 1 month ago

/cc @dhiller

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/project-infra/blob/main/OWNERS)~~ [dhiller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dhiller commented 1 month ago

@ksimon1 I overlooked that if you enable tide you also need to enable lgtm and approve plugins.

I'll fetch an example PR later and attach it to this PR.

https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3513/check-prow-config/1810283836047626240

dhiller commented 1 month ago

/lgtm cancel

dhiller commented 1 month ago

@ksimon1 I overlooked that if you enable tide you also need to enable lgtm and approve plugins.

I'll fetch an example PR later and attach it to this PR.

prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_project-infra/3513/check-prow-config/1810283836047626240

Here's the docs about merge automation: https://github.com/kubevirt/community/blob/main/docs/add-merge-automation-to-your-repository.md Here's an example PR: https://github.com/kubevirt/project-infra/pull/653/files

ksimon1 commented 1 month ago

@dhiller can you please check this PR again?

kubevirt-bot commented 1 month ago

@ksimon1: Updated the following 2 configmaps:

In response to [this](https://github.com/kubevirt/project-infra/pull/3513): >**What this PR does / why we need it**: >chore: enable branch protection for kubevirt-tekton-tasks > > >**Release note**: >``` >NONE >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.