kubevirt / project-infra

Project infrastructure administrative tools
Apache License 2.0
25 stars 130 forks source link

bazel: move to vendoring go dependencies #3522

Open dhiller opened 1 month ago

dhiller commented 1 month ago

What this PR does / why we need it:

Replaces the bazel dependency management for go repositories with pure go mod vendoring.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

/cc @brianmcarey

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from dhiller. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/project-infra/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dhiller commented 1 month ago

/cc @xpivarc

FYI: since kubernetes-sigs/test-infra and kubernetes-sigs/prow moved away from using bazel, maintaining it has become more of a burden - so we think it's best to remove it and work with go tools only.

dhiller commented 1 month ago

/test pull-project-infra-test-robots

dhiller commented 1 month ago

/rehearse ?

kubevirt-bot commented 1 month ago

Rehearsal is available for the following jobs in this PR:

pull-project-infra-test-robots

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller commented 1 month ago

/rehearse pull-project-infra-test-robots

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

rehearsal-pull-project-infra-test-robots

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller commented 1 month ago

/test pull-project-infra-test-robots

xpivarc commented 1 month ago

/cc @xpivarc

FYI: since kubernetes-sigs/test-infra and kubernetes-sigs/prow moved away from using bazel, maintaining it has become more of a burden - so we think it's best to remove it and work with go tools only.

I like vendoring :+1:

dhiller commented 1 month ago

/rehearse

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller commented 1 month ago

/rehearse pull-project-infra-test-robots

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller commented 1 month ago

/test pull-project-infra-test-robots

dhiller commented 1 month ago

/test pull-project-infra-test-bazel-config

dhiller commented 1 month ago

/rehearse pull-project-infra-test-bazel-config

kubevirt-bot commented 1 month ago

Rehearsal jobs created for this PR:

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

dhiller commented 1 month ago

/test all

dhiller commented 1 month ago

/test all

dhiller commented 3 weeks ago

/test all

kubevirt-bot commented 3 weeks ago

@dhiller: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
rehearsal-pull-project-infra-test-robots 588fdeedd9a0448e346a1821da9ba6f4c46aac91 link unknown /test pull-project-infra-test-robots
pull-project-infra-ci-search-deploy-test e65e1a2dfd1ffe12220d8e413b132b00e1d6b3be link true /test pull-project-infra-ci-search-deploy-test
pull-project-infra-test-bazel-config e65e1a2dfd1ffe12220d8e413b132b00e1d6b3be link true /test pull-project-infra-test-bazel-config
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).