kubevirt / project-infra

Project infrastructure administrative tools
Apache License 2.0
25 stars 130 forks source link

fix,bootstrap: Fix sed to change to permissive for short-name-mode #3529

Closed brianmcarey closed 1 month ago

brianmcarey commented 1 month ago

What this PR does / why we need it:

There was a recent change in how the containers-common rpm is built[1] which led to a slight formatting change to registries.conf.

This results in short-name-mode remaining in enforcing mode which breaks a number of jobs that still do not use full names for images[2]

[1] https://github.com/containers/common/commit/5c5b1120aaa2970d1b6c961ba2d48996fb240c6a [2] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirtci/1209/check-provision-alpine-with-test-tooling/1812792004837380096#1:build-log.txt%3A792

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

/cc @dhiller

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/project-infra/blob/main/OWNERS)~~ [dhiller] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment