search

kubevirt / project-infra

Project infrastructure administrative tools
Apache License 2.0
26 stars 137 forks source link

fix: add -c param to kubevirt-tekton-tasks script #3537

Closed ksimon1 closed 3 months ago

ksimon1 commented 3 months ago

What this PR does / why we need it: fix: add -c param to kubevirt-tekton-tasks script

The git-pr.sh script requires -c parameter which holds the command. This commit updates the teton-tasks periodics script to pass the -c parameter to git-pr.sh script

Which issue(s) this PR fixes: Fixes https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-update-libguestfs-container-version/1812668534048690176

Release note:

fix: add -c param to kubevirt-tekton-tasks script
0xFelix commented 3 months ago

/rehearse all

kubevirt-bot commented 3 months ago

Rehearsal jobs created for this PR:

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

ksimon1 commented 3 months ago

@dhiller can you please check this PR?

ksimon1 commented 3 months ago

@brianmcarey can you please check this PR?

kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[github/ci/prow-deploy/files/jobs/kubevirt/kubevirt-tekton-tasks/OWNERS](https://github.com/kubevirt/project-infra/blob/main/github/ci/prow-deploy/files/jobs/kubevirt/kubevirt-tekton-tasks/OWNERS)~~ [brianmcarey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 3 months ago

@ksimon1: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

In response to [this](https://github.com/kubevirt/project-infra/pull/3537): >**What this PR does / why we need it**: >fix: add -c param to kubevirt-tekton-tasks script > >The git-pr.sh script requires -c parameter which holds the command. This commit updates the teton-tasks periodics script to pass the -c parameter to git-pr.sh script > >**Which issue(s) this PR fixes**: >Fixes https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/logs/periodic-update-libguestfs-container-version/1812668534048690176 > >**Release note**: >``` >fix: add -c param to kubevirt-tekton-tasks script >``` > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.