search

kubevirt / ssp-operator

Operator that deploys additional KubeVirt resources
Apache License 2.0
29 stars 47 forks source link

[release-v0.18] fix: add required labels to pods #1006

Closed kubevirt-bot closed 1 month ago

kubevirt-bot commented 2 months ago

This is an automated cherry-pick of #787

/assign codingben

Add required labels to template-validator and vm-console-proxy pods.
lyarwood commented 2 months ago

/approve /lgtm

kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lyarwood

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/ssp-operator/blob/release-v0.18/OWNERS)~~ [lyarwood] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codingben commented 2 months ago

I'm not sure what caused the functional tests to fail, but I saw lots of timeouts. I'll retrigger it again.

/retest

codingben commented 2 months ago

I'll run functional tests myself. This is weird because it didn't fail in release-v0.19 after it was backported.

0xFelix commented 2 months ago

Timed out waiting for SSP to be in phase Deployed.

This looks suspicious.

codingben commented 1 month ago

I'll try to run the tests again, just to be sure that there is no infrastructure issue.

/retest

openshift-ci[bot] commented 1 month ago

@kubevirt-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-functests 18cfc90aee2425cd97278dfcb1b3ee2a7f208c84 link true /test e2e-upgrade-functests
ci/prow/e2e-single-node-functests 18cfc90aee2425cd97278dfcb1b3ee2a7f208c84 link true /test e2e-single-node-functests
ci/prow/e2e-functests 18cfc90aee2425cd97278dfcb1b3ee2a7f208c84 link true /test e2e-functests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
codingben commented 1 month ago

The reported bug mentioned only virt-template-validator and this PR also changes vm-console-proxy. I'll open a new PR to change only virt-template-validator.

codingben commented 1 month ago

/close

kubevirt-bot commented 1 month ago

@codingben: Closed this PR.

In response to [this](https://github.com/kubevirt/ssp-operator/pull/1006#issuecomment-2245008901): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
akrejcir commented 1 month ago

Why not fix the vm-console-proxy resources too?

codingben commented 1 month ago

Why not fix the vm-console-proxy resources too?

It wasn't mentioned in the Jira issue that also vm-console-proxy is missing required labels. I'd prefer to keep it purposed.

akrejcir commented 1 month ago

If the same issue is with the proxy, and it was fixed in one PR in main, then why separate it for backports?

is it related to the failing CI?